28 May
2008
28 May
'08
4:02 p.m.
On Thu, May 22, 2008 at 06:36:16PM +0100, Daniel P. Berrange wrote:
The capabilities.c file was not checking for NULL pointers when cleaning up after some failed allocations, and so deferencing a NULL.
The qparams.c file was not calling virRaiseError upon failure so there wasn't any indication of why it failed
The qemu_conf.c file was not free'ing the sound card data in several places
Looks fine, +1 Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/