Re: [libvirt PATCH 01/39] cpu_x86: Drop noTSX hint for incompatible CPUs

The hint was introduced a long time ago when broken TSX implementation was found in Haswell and Broadwell CPUs. Since then many more CPUs with TSX were introduced and and disabled due to TAA vulnerability. Thus the hint is not very useful and I think removing it is a better choice then updating it to cover all current noTSX models.

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com&gt; --- src/cpu/cpu_x86.c | 42 ++++++------------------------------------ 1 file changed, 6 insertions(+), 36 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index ce15bb0454..eeb16c2763 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -1937,7 +1937,6 @@ virCPUx86Compare(virCPUDefPtr host, bool failIncompatible) { virCPUCompareResult ret = VIR_CPU_COMPARE_ERROR; - virCPUx86MapPtr map; virCPUx86ModelPtr model = NULL;

char *message = NULL;