On a Friday in 2024, Michal Privoznik wrote:
Currently, virSocketSendMsgWithFDs() reports two errors:
1) if CMSG_FIRSTHDR() fails, 2) if sendmsg() fails.
Well, the latter sets an errno, so caller can just use virReportSystemError(). And the former - it is very unlikely to fail because memory for whole control message was allocated just a few lines above.
The motivation is to unify behavior of virSocketSendMsgWithFDs() and virSocketSendFD() because the latter is just a subset of the former (will be addressed later).
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- po/POTFILES | 1 - src/ch/ch_process.c | 6 ++++-- src/util/virsocket.c | 14 ++------------ 3 files changed, 6 insertions(+), 15 deletions(-)
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano