Re: [libvirt] [PATCH v2] bridge driver: extract platform specifics
Hi Eric!
Any chance you could take a look at it? I know that patches could hang
much longer, but this one blocks my further work on making bridge driver
work on FreeBSD.
After we're done with the split, you will be able to rest from me
for some time because proper FreeBSD implementation will not be very fast ;)
Roman Bogorodskiy wrote:
* Move platform specific things (e.g. firewalling and route
collision checks) into bridge_driver_platform
* Create two platform specific implementations:
- bridge_driver_linux: Linux implementation using iptables,
it's actually the code moved from bridge_driver.c
- bridge_driver_nop: dumb implementation that does nothing
---
src/network/bridge_driver_platform.h | 79 ++++
src/network/bridge_driver.c | 708 +--------------------------------
src/network/bridge_driver_linux.c | 709 ++++++++++++++++++++++++++++++++++
src/network/bridge_driver_nop.c | 78 ++++
src/network/bridge_driver_platform.c | 32 ++
po/POTFILES.in | 1 +
src/Makefile.am | 5 +-
7 files changed, 903 insertions(+), 709 deletions(-)
create mode 100644 src/network/bridge_driver_platform.h
create mode 100644 src/network/bridge_driver_linux.c
create mode 100644 src/network/bridge_driver_nop.c
create mode 100644 src/network/bridge_driver_platform.c
Roman Bogorodskiy
Attachments:
- attachment.sig (application/pgp-signature — 488 bytes)