Re: [libvirt] [PATCH v2 15/15] qemuxml2argvtest: Test os.firmware autoselection

On 3/11/19 4:27 PM, Daniel P. Berrangé wrote: > On Thu, Mar 07, 2019 at 10:29:25AM +0100, Michal Privoznik wrote: >> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; >> --- >>   tests/Makefile.am                             |  4 +- >>   ...arch64-os-firmware-efi.aarch64-latest.args | 37 ++++++++++ >>   .../aarch64-os-firmware-efi.xml               | 30 ++++++++ >>   .../os-firmware-bios.x86_64-latest.args       | 39 +++++++++++ >>   tests/qemuxml2argvdata/os-firmware-bios.xml   | 68 +++++++++++++++++++ >>   ...os-firmware-efi-secboot.x86_64-latest.args | 43 ++++++++++++ >>   .../os-firmware-efi-secboot.xml               | 68 +++++++++++++++++++ >>   .../os-firmware-efi.x86_64-latest.args        | 42 ++++++++++++ >>   tests/qemuxml2argvdata/os-firmware-efi.xml    | 68 +++++++++++++++++++ >>   tests/qemuxml2argvtest.c                      | 17 +++++ >>   .../aarch64-os-firmware-efi.xml               |  1 + >>   tests/qemuxml2xmloutdata/os-firmware-bios.xml |  1 + >>   .../os-firmware-efi-secboot.xml               |  1 + >>   tests/qemuxml2xmloutdata/os-firmware-efi.xml  |  1 + >>   tests/qemuxml2xmltest.c                       | 27 ++++++++ >>   15 files changed, 446 insertions(+), 1 deletion(-) >>   create mode 100644 >> tests/qemuxml2argvdata/aarch64-os-firmware-efi.aarch64-latest.args >>   create mode 100644 tests/qemuxml2argvdata/aarch64-os-firmware-efi.xml >>   create mode 100644 >> tests/qemuxml2argvdata/os-firmware-bios.x86_64-latest.args >>   create mode 100644 tests/qemuxml2argvdata/os-firmware-bios.xml >>   create mode 100644 >> tests/qemuxml2argvdata/os-firmware-efi-secboot.x86_64-latest.args >>   create mode 100644 tests/qemuxml2argvdata/os-firmware-efi-secboot.xml >>   create mode 100644 >> tests/qemuxml2argvdata/os-firmware-efi.x86_64-latest.args >>   create mode 100644 tests/qemuxml2argvdata/os-firmware-efi.xml >>   create mode 120000 >> tests/qemuxml2xmloutdata/aarch64-os-firmware-efi.xml >>   create mode 120000 tests/qemuxml2xmloutdata/os-firmware-bios.xml >>   create mode 120000 >> tests/qemuxml2xmloutdata/os-firmware-efi-secboot.xml >>   create mode 120000 tests/qemuxml2xmloutdata/os-firmware-efi.xml > > Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; > Thank you guys both. I've merged these. I'm pleasantly surprised it took only two iterations :-)