Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive
Il 15/03/2013 15:43, Eric Blake ha scritto:
On 03/15/2013 08:29 AM, Daniel P. Berrange wrote:
> On Mon, Feb 25, 2013 at 06:44:21PM +0100, Paolo Bonzini wrote:
>> QEMU added -drive in 2007, and NBD in 2008. Both appeared first in
>> release 0.10.0. Thus the code to support network disks without -drive
>> is dead, and in fact it incorrectly escapes commas. Drop it.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini(a)redhat.com>
>> ---
>> src/qemu/qemu_command.c | 53 ++-----------------------------------------------
>> 1 file changed, 2 insertions(+), 51 deletions(-)
>
> ACK
Pushed.
Ok to push 3-10 and 14 too? Then I'll send the coding style adjustments
that Osier requested (but Dan acked nevertheless) and 11-13 which need a
bit more work.
Paolo