Re: [libvirt] [PATCH] qemu: check for json allocation failure

On 10/13/2011 02:41 AM, Peter Krempa wrote:

On 10/13/2011 02:13 AM, Eric Blake wrote:

...

diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 18d1c9f..cd8f1e5 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -1364,6 +1364,9 @@ int qemuMonitorJSONGetBlockInfo(qemuMonitorPtr mon, virJSONValuePtr reply = NULL; virJSONValuePtr devices;

+ if (!cmd) + return -1; + ret = qemuMonitorJSONCommand(mon, cmd,&reply); if (ret == 0) ret = qemuMonitorJSONCheckError(cmd, reply);

ACK,

Pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org