Re: [PATCH] Fix missing-field-initializers error
在 2022/1/13 0:22, Daniel P. Berrangé 写道:
On Thu, Jan 13, 2022 at 12:11:47AM +0800, huangy81(a)chinatelecom.cn
wrote:
> From: Hyman Huang(黄勇) <huangy81(a)chinatelecom.cn>
>
> When compile libvirt via ninja tool with default configuration,
> it report the error message as the following:
> "missing initializer for field 'path' of
'virTPMBinaryInfo'".
> So initialize the 'path' field in 'virTPMBinaryInfo' with
'NULL'.
I'm wondering why this isn't reported by our automated CI.
What OS distro / GCC / CLang version are you seeing this with ?
The following is my
work env:
OS distro: CentOS Linux release 7.9.2009 (Core)
GCC version: gcc (GCC) 7.5.0
ninja: 1.10.2
meson: 0.55.1
The following step can reproduce the error:
meson builddir
meson configure --prefix=/usr/local
ninja -C builddir
Thanks for quick response.
Hyman
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81(a)chinatelecom.cn>
> ---
> src/util/virtpm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/util/virtpm.c b/src/util/virtpm.c
> index cf4c7c4..a02d933 100644
> --- a/src/util/virtpm.c
> +++ b/src/util/virtpm.c
> @@ -122,13 +122,16 @@ typedef struct _virTPMBinaryInfo {
>
> static virTPMBinaryInfo swtpmBinaries[VIR_TPM_BINARY_LAST] = {
> [VIR_TPM_BINARY_SWTPM] = {
> + .path = NULL,
> .parm = "socket",
> .capsParse = virTPMSwtpmFeatureTypeFromString,
> },
> [VIR_TPM_BINARY_SWTPM_SETUP] = {
> + .path = NULL,
> .capsParse = virTPMSwtpmSetupFeatureTypeFromString,
> },
> [VIR_TPM_BINARY_SWTPM_IOCTL] = {
> + .path = NULL,
> },
> };
>
> --
> 1.8.3.1
>
>
Regards,
Daniel