Re: [PATCH v7 03/18] config: Introduce ThrottleGroup and corresponding XML parsing

On Wed, Feb 12, 2025 at 04:05:22PM +0530, Harikumar Rajkumar wrote: When this patch was posted in v6: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/V... The authorship was credited to Chun Feng Wu, and also had their signed-off-by. If picking up someone else's work, normally the git "Author" should be left unchanged, only the "Comitter" record changes (automatically) to your name. Similarly the existing Signed-Off-By should be left intact, with your own Signed-Off-By just appended, ideally with an initialed note about what you altered from the original patch. eg the end of the commit would look like this: Signed-off-by: Chun Feng Wu <danielwuwy(a)163.com&gt; [HR: changed blah, blah & blah ] Signed-off-by: Harikumar Rajkumar <harirajkumar230(a)gmail.com&gt; Same applies to pretty much every patch in this series which were all creditted to Chun Feng Wu previously. With regards, Daniel