On Fri, Sep 05, 2008 at 03:20:32PM +0100, Daniel P. Berrange wrote:
On Fri, Aug 29, 2008 at 12:54:18PM +0400, Evgeniy Sokolov wrote:
On Thu, Aug 28, 2008 at 12:06:08PM +0400, Evgeniy Sokolov wrote:
The biggest flaw I see currently is that the openvz driver doesn't load the existing device config for networks or filesystems of existing VMs, so you can't see that info in the XML dump Yes. Good note. I will implement it. - /*get VCPU*/ - ret = openvzReadConfigParam(veid, "CPUS", temp, sizeof(temp)); - if (ret < 0) { - openvzError(conn, VIR_ERR_INTERNAL_ERROR, - _("Cound not read config for container %d"), veid); - goto error; - } else if (ret > 0) { - vmdef->vcpus = strtoI(temp); - } Why did you remove loading VCPUs and always set = 1 ?
Stupid mistake during a manual merge. Here's an updated patch which fixes that mistake
The patch looks good now.
Thanks - i've committed this patch now, so now all our drivers are using the same XML processing APIs !
Excellent !!! Kudos for this, this is a huge long term improvement ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/