On 06/24/2016 04:23 PM, Laine Stump wrote:
On 06/24/2016 07:11 AM, John Ferlan wrote:
On 06/22/2016 01:37 PM, Laine Stump wrote:
These functions all need to be called from a utility function that must be located in the util directory, so we move them all into util/virnetdevip.[ch] now that it exists.
Function and struct names were appropriately changed for the new location, but all code is unchanged aside from motion and renaming. --- src/conf/domain_conf.c | 36 ++++++------- src/conf/domain_conf.h | 16 ++---- src/conf/network_conf.c | 16 +++--- src/conf/network_conf.h | 4 +- src/conf/networkcommon_conf.c | 107 ++++---------------------------------- src/conf/networkcommon_conf.h | 55 +++++++------------- src/libvirt_private.syms | 16 +++--- src/lxc/lxc_container.c | 12 ++--- src/lxc/lxc_native.c | 12 ++--- src/network/bridge_driver.c | 14 ++--- src/network/bridge_driver_linux.c | 6 +-- src/util/virnetdevip.c | 69 ++++++++++++++++++++++++ src/util/virnetdevip.h | 29 +++++++++++ 13 files changed, 191 insertions(+), 201 deletions(-)
The one naming thing that "could" have changed as well is to keep the "Def" portion (virNetDevIPRouteDefFree, virNetDevIPRouteDefParseXML, virNetDevIPRouteDefFormat, virNetDevIPRouteDefCreate). Generally I'd say it's a coin flip, but to be consistent since they're handling the virNetworkRouteDefPtr, then I guess without "knowing" the API names I'd start searching "NetworkRouteDef{Parse|Format}" in order to find the code that dealt with it (the libvirt consistency argument).
But when the structures get below a certain level of complexity (or maybe it's that they're nested deep enough, dunno), they tend to lose the Def suffix - virNetDevBandwith, virNetDevVlan virDomainDeviceInfo virNetDevVPortProfile...
OK nm then... It was just one of those consistency things. John