On Thu, Oct 21, 2010 at 11:45:15AM -0400, Stefan Berger wrote:
On 10/21/2010 10:37 AM, Daniel P. Berrange wrote:
Recent changes to how filters are being instantiated require follow-up changes to the test suite. The following changes are related to
- usage of 'ctdir' - changes to the host's incoming filter chain
Signed-off-by: Stefan Berger<stefanb@us.ibm.com> Can you resend without the whitespace problems. It is pretty hard to read the diff to understand what has actually changed, because
On Thu, Oct 21, 2010 at 07:58:34AM -0400, Stefan Berger wrote: the mail client has inserted arbitrary line breaks throughout :-(
Regards, Daniel I was using Thunderbird... let me retry with Evolution. I'll also send it as an attachment.
Most reliable is to just use git send-email :-) The kernel Documentation/email-clients.txt has some tips on how to stop thunderbird mangling patches, but it sounds painful... [quote] By default, thunderbird likes to mangle text, but there are ways to coerce it into being nice. - Under account settings, composition and addressing, uncheck "Compose messages in HTML format". - Edit your Thunderbird config settings to tell it not to wrap lines: user_pref("mailnews.wraplength", 0); - Edit your Thunderbird config settings so that it won't use format=flowed: user_pref("mailnews.send_plaintext_flowed", false); - You need to get Thunderbird into preformat mode: . If you compose HTML messages by default, it's not too hard. Just select "Preformat" from the drop-down box just under the subject line. . If you compose in text by default, you have to tell it to compose a new message in HTML (just as a one-off), and then force it from there back to text, else it will wrap lines. To do this, use shift-click on the Write icon to compose to get HTML compose mode, then select "Preformat" from the drop-down box just under the subject line. - Allows use of an external editor: The easiest thing to do with Thunderbird and patches is to use an "external editor" extension and then just use your favorite $EDITOR for reading/merging patches into the body text. To do this, download and install the extension, then add a button for it using View->Toolbars->Customize... and finally just click on it when in the Compose dialog. [/quote] Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|