Re: [libvirt] [PATCH] blockjob: Fix a error checking of blockjob status in some case

On 01/19/2018 09:03 AM, Jie Wang wrote: > offset and len can also be equal to 0 on failed if blockjob return > status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad > state", this bug can be reproduced easily if you perform a async > block job on read only filesystem, so it's very worthwhile for us to > check 'error' in this case. Perhaps better said: Commit id 'bc444666f' added a check if the returned data buffer had an error, but failed to adjust the event from VIR_DOMAIN_BLOCK_JOB_COMPLETED to VIR_DOMAIN_BLOCK_JOB_FAILED in order to propagate an error such as "File descriptor in bad state" that may be returned from QEMU when both @offset and @len are set to 0 such as is the case when performing an async block job read on a read only filesystem. If that adjustment is fine with you and anyone else that cares to read this response, then I'll make the adjustment and push... Reviewed-by: John Ferlan <jferlan(a)redhat.com&gt;