Re: [libvirt] [PATCH 0/5]: Rework iSCSI lun handling

On Mon, Jun 16, 2008 at 04:10:42PM +0200, Stefan de Konink wrote: > Chris Lalancette schreef: >> Stefan de Konink wrote: >>> Chris Lalancette schreef: >>>> 4) Further lessen our dependence on direct calls to iscsiadm, in case >>>> they >>>> change the output in the future. >>> How are you looking against this previous proposed setup where we will >>> give an updated Makefile to the open-iscsi folks (to build >>> libopen-iscsi.so) and implement an specific open-iscsi iscsi driver that >>> uses the exact same functions as open-iscsi does itself? >> Yeah, it's not a bad plan at all. Someone just needs to work with upstream >> open-iscsi tools to split their stuff out into a library. I'm totally for >> this >> type of implementation; not only will we not have to fork and exec for >> some of >> this stuff, we should be able to get better error messages as well. > The I have looked at there Makefile before, and build this. They already > mark there 'libraries'. So it would be only one update... As I've said before, while this is useful in the long term, this doesn't make the existing code go away. We need to be able to spport iSCSI on RHEL-5 vintage which has no such library.