Re: [libvirt] [PATCH 5/8] Add domainXMLFromNative/domainXMLToNative to libxl driver

Markus Groß wrote: > --- > configure.ac | 2 + > daemon/Makefile.am | 3 + > src/Makefile.am | 8 ++- > src/libxl/libxl_driver.c | 94 +++++++++++++++++++++++++++++++++++++++++++++- > 4 files changed, 102 insertions(+), 5 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 12bf0f6..3519011 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -607,6 +607,8 @@ AM_CONDITIONAL([WITH_XEN], [test "$with_xen" = "yes"]) > AC_SUBST([XEN_CFLAGS]) > AC_SUBST([XEN_LIBS]) > > +AM_CONDITIONAL([WITH_XENXS], [test "$with_libxl" = "yes" || test "$with_xen" = "yes"]) > + > dnl > dnl check for kernel headers required by xen_inotify > dnl > diff --git a/daemon/Makefile.am b/daemon/Makefile.am > index 9e3a557..4344127 100644 > --- a/daemon/Makefile.am > +++ b/daemon/Makefile.am > @@ -108,6 +108,9 @@ endif > > if WITH_LIBXL > libvirtd_LDADD += ../src/libvirt_driver_libxl.la > + libvirtd_LDADD += ../src/libvirt_xenxs.la > + libvirtd_LDADD += ../src/libvirt_util.la > + libvirtd_LDADD += ../src/libvirt_conf.la > endif > I'd like to get another opinion on this hunk. Although I cant find any issues with it, I'd just like to ensure there is not a more appropriate way to add these libs.