On Tue, Mar 22, 2011 at 03:45:20PM -0600, Eric Blake wrote:
Many times, we don't notice a bug in src/libvirt_private.syms until someone attempts a build with modules enabled. Having autobuild.sh stress that can only help.
* autobuild.sh: Add test of --with-driver-modules. Update mingw build to skip recent driver additions. --- autobuild.sh | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/autobuild.sh b/autobuild.sh index 54fb273..cbccfa9 100755 --- a/autobuild.sh +++ b/autobuild.sh @@ -61,6 +61,14 @@ if [ -f /usr/bin/rpmbuild ]; then -ba --clean libvirt.spec fi
+# Test build with modules +make distclean +../autogen.sh --prefix="$AUTOBUILD_INSTALL_ROOT" \ + --with-driver-modules \ + --enable-compile-warnings=error +make check +
This won't really check very much. What we really want is to create a simple test case, that links to the main libvirt.so (ie not the test_libvirt.so which omits symbol versions), and then does a dlopen() on each module we built & reports error if any fail. I'd also be inclined to just add '--with-driver-modules' to the existing autogen.sh line in autobuild.sh, rather than doing yet another clean+build cycle.
@@ -83,6 +91,8 @@ if [ -x /usr/bin/i686-pc-mingw32-gcc ]; then --without-openvz \ --without-one \ --without-phyp \ + --without-xenapi \ + --without-libxl \ --without-netcf \ --without-audit \ --without-dtrace \
Actually, we shouldn't need these here. Ideally we'd get to the point where we don't need *any* of these --without-XXX options in autobuild.sh. It should be automatically figuring out what is available itself. Only in the RPM builds should we have use --with and --without flags to strictly control what is built. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|