Re: [libvirt-ci PATCH v2 07/13] lcitool: Update the config values with internal playbook settings
On Tue, 2020-05-12 at 16:42 +0200, Erik Skultety wrote:
- extra_vars = {
+ self._config.values.update({
"base": base,
"playbook_base": playbook_base,
- "root_password_file": root_pass_file,
- "flavor": flavor,
"selected_projects": selected_projects,
"git_remote": git_remote,
"git_branch": git_branch,
- "gitlab_url_file": gitlab_url_file,
- "gitlab_runner_token_file": gitlab_runner_token_file,
- }
+ })
I still think this would look better as
extra_vars = self._config.values
extra_vars.update({
...
}
but either way my
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
still stands.
--
Andrea Bolognani / Red Hat / Virtualization