On Thu, Mar 03, 2011 at 04:01:35PM -0700, Eric Blake wrote:
On 03/03/2011 07:21 AM, Daniel P. Berrange wrote:
The event loop implementation is used by more than just the daemon, so move it into the shared area.
* daemon/event.c, src/util/event_poll.c: Renamed * daemon/event.h, src/util/event_poll.h: Renamed * tools/Makefile.am, tools/console.c, tools/virsh.c: Update to use new virEventPoll APIs * daemon/mdns.c, daemon/mdns.c, daemon/Makefile.am: Update to use new virEventPoll APIs --- daemon/Makefile.am | 1 - daemon/event.c | 706 ---------------------------------------------- daemon/event.h | 134 --------- daemon/libvirtd.c | 18 +- daemon/mdns.c | 6 +- src/Makefile.am | 1 + src/libvirt_private.syms | 13 + src/util/event_poll.c | 705 +++++++++++++++++++++++++++++++++++++++++++++ src/util/event_poll.h | 132 +++++++++ tools/Makefile.am | 1 - tools/console.c | 6 +- tools/virsh.c | 16 +- 12 files changed, 874 insertions(+), 865 deletions(-) delete mode 100644 daemon/event.c delete mode 100644 daemon/event.h create mode 100644 src/util/event_poll.c create mode 100644 src/util/event_poll.h
git config diff.rename true
That cuts your 66k message down to 25k, making it easier to review.
ACK if you squash this in (did you forget to run 'make check'?):
Urgh yes. I find it really annoying that plain 'make' does not cause the test suite to be compiled anymore:-( It certainly used to, but we lost it at some point & I've not checked where yet. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|