Re: [libvirt] [PATCH 1/2] libxl: expose multiple emulators per guest in the capabilities XML
On Mon, Apr 29, 2013 at 12:54:55PM -0600, Jim Fehlig wrote:
Daniel P. Berrange wrote:
>
>
> NB, for any single (arch, domain, os_type) triple, we should only
> report one <guest> in the capabilities XML. IIUC, your code above
> report cause us to have two entries for the same triple.
Right. David mentioned in the cover letter that the resulting
capabilities would looks something like
<arch name='i686'>
<wordsize>32</wordsize>
<machine>xenfv</machine>
<domain type='xen'>
<emulator>/usr/lib64/xen/bin/qemu-dm</emulator>
<loader>/usr/lib/xen/boot/hvmloader</loader>
</domain>
<domain type='xen'>
<emulator>/usr/lib64/xen/bin/qemu-system-i386</emulator>
<loader>/usr/lib/xen/boot/hvmloader</loader>
</domain>
</arch>
Yep, that would not be right, because there are two <domain>
elements for type='xen' here. Each domain type is only allowed
to exist once. So what you really want is something like
<arch name='i686'>
<emulator>/usr/lib64/xen/bin/qemu-dm</emulator>
<loader>/usr/lib/xen/boot/hvmloader</loader>
<wordsize>32</wordsize>
<machine>xenfv</machine>
<domain type='xen'>
</domain>
</arch>
(Or choose the other qemu binary - which ever is declared as
the "preferred" one).
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|