On Wed, Nov 03, 2021 at 04:15:49AM -0500, Andrea Bolognani wrote:
On Wed, Oct 06, 2021 at 10:58:29AM -0500, Andrea Bolognani wrote:
> Dan, should I consider your criticism of the approach an explicit
> NACK? If not, I will pick up Pavel's ACK and push this.
>
> I think the latter is the right thing to do, on the basis that it
> will leave us in a place that's strictly better than the status quo
> and that - to the best of my knowledge - no alternative that doesn't
> itself suffer from known drawbacks has been proposed.
Since no actual NACK has been raised over the past three months, nor
has an alternative implementation materialized, I went ahead and
pushed the change.
This broke FreeBSD CI
https://gitlab.com/libvirt/libvirt/-/pipelines/400924210/failures
Regards,
Daniel
--
|:
https://berrange.com -o-
https://www.flickr.com/photos/dberrange :|
|:
https://libvirt.org -o-
https://fstop138.berrange.com :|
|:
https://entangle-photo.org -o-
https://www.instagram.com/dberrange :|