Re: [libvirt] [PATCH v2 1/5] domain: Fix unknown flags diagnosis in virDomainGetXMLDesc
On 2/19/19 2:24 PM, Eric Blake wrote:
> BTW: For the two callers that pass all 3 maybe it'd be good to change
> those to pass VIR_DOMAIN_XML_COMMON_FLAGS. Currently:
>
> * qemuMigrationCookieXMLFormat
> * qemuDomainSaveImageDefineXML
Makes sense, although I might split it as a separate patch.
Actually, no, it doesn't make sense. If VIR_DOMAIN_XML_COMMON_FLAGS
gains a new flag, we don't want these callers to start outputting new
information merely because they used the convenience macro. (That is,
the macro is good for virCheckFlags(), to allow a driver to
automatically support a new public flag by deferring to the common
domain_conf implementation's support of the new flag; but it is not good
for internal uses where we are generating specific output without
regards to flags passed in through the public API).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org