Re: [libvirt] xenUnifiedDomainLookupByName error handling
On Wed, Jan 14, 2009 at 10:38:02PM +0000, Daniel P. Berrange wrote:
> # virsh start domu-defefe
> 12:09:30.581: error : Domain not found: xenUnifiedDomainLookupByName
> libvir: Xen error : Domain not found: xenUnifiedDomainLookupByName
> libvir: Xen error : Domain not found: xenUnifiedDomainLookupByName
> error: failed to get domain 'domu-defefe'
>
> It doesn't seem right to be reporting errors like this. What's the
> intent? Most of xenUnifiedError() seems to be internal errors, but many
> of them are just clients doing the wrong thing...
In the virsh case, it really should be just registering a callack to
disable the default fprintf() of errors, since it always prints its
own error message in a more use friendly format. We've done this in
virt-install already for the same reason.
This won't help differentiate between "shouldn't happen" and "will
happen" errors though. Also, it would reveal ugly internal details in
any error messages, which are only appropriate for "libvirt is broken"
cases...
regards
john