Re: [libvirt] [PATCH] qemu: include kernel version in QEMU log file
On Fri, May 18, 2018 at 08:16:39PM +0200, Kashyap Chamarthy wrote:
On Fri, May 18, 2018 at 12:24:32PM +0100, Daniel P. Berrangé wrote:
> We currently print the libvirt and qemu version strings into the
> per-guest logfile. It would be useful to know what kernel is running
> too, so add that.
>
> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
> ---
> src/qemu/qemu_process.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
I applied your patch and built libvirt locally; then I started my
freshly-built libvirt, et al:
[...]
When you start a guest with "sudo ./tools/virsh start
cvm2", where will
the per-guest log file go? Is it even configurable? I never tried this
before.
[...]
What am I missing? I'm curious how you tested it.
Eric Blake on IRC reminded me that if I built with 'autogen.sh --system'
will, then the per-guest log should go to the standard location.
On my above compile, I didn't use '--system'; re-doing a fresh compile
with 'autogen.sh --system' indeed results in the Linux kernel version
being printed in the per-guest log, in the stndard location:
[...]
2018-05-18 18:52:15.725+0000: starting up libvirt version: 4.4.0, qemu version:
2.10.1(qemu-2.10.1-2.fc27), kernel: 4.14.16-300.fc27.x86_64 ...
[...]
FWIW:
Reviewed-by and Tested-by: Kashyap Chamarthy <kchamart(a)redhat.com>
--
/kashyap