On Tue, Apr 02, 2019 at 01:24:37PM +0200, Andrea Bolognani wrote:
On Tue, 2019-04-02 at 12:43 +0200, Ján Tomko wrote:
On Mon, Apr 01, 2019 at 06:50:51PM +0200, Andrea Bolognani wrote:
+If you're interested in the full list of changes made to libvirt since +the project was started, you can clone the git repository from + + https://libvirt.org/git/libvirt.git + +and browse them locally using your favorite git history viewer or, +alternatively, browse them online at + + https://libvirt.org/git/?p=libvirt.git;a=log
And this points the developer to the libvirt.git, which is already linked in README-hacking
I didn't consider the mention in README-hacking, though I'd say this is slightly different because 1) it also points to the Web-browsable version of the git log and 2) people looking for the ChangeLog will probably not go poking at README-hacking of all places.
I'd rather drop the ChangeLog file completely
I personally don't have a problem with the idea, but I seem to recall a ChangeLog being required by the GNU coding standard, which we are at least formally following; I expect moving away from it to be an at least somewhat controversial change...
Okay, let's look into that later.
So perhaps we could get rid of the 12+ MiB of garbage right now, and then suggest dropping these remaining dozen lines as a follow up? :)
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano