Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine
On Mon, Nov 25, 2019 at 4:40 PM Daniel P. Berrangé <berrange(a)redhat.com> wrote:
On Mon, Nov 25, 2019 at 03:45:35PM +0100, Aleksandar Markovic wrote:
> On Monday, November 25, 2019, Philippe Mathieu-Daudé <philmd(a)redhat.com>
> wrote:
>
> > The r4k machine was introduced in 2005 (6af0bf9c7) and its last
> > logical change was in 2005 (9542611a6). After we can count 164
> > maintenance commits (QEMU API changes) with the exception of
> > 1 fix in 2015 (memory leak, commit 3ad9fd5a).
> >
> >
> Please don't start any deprecation process. This requires certain
> consultation within my company. Rest assured that everyone's opinion will
> be taken into account while doing consiltation.
The idea of having a deprecation process is precisely to
allow time for people like to provide feedback before any
deletion takes place. So this is not a reason to delay
starting of deprecation.
What you said is fine, Daniel, I understand the idea, and it should be
that way. But I didn't ask for some lengthy negotiation, or waiting
for someone for months, but I just wanted to check within company if
all relevant people (that do not read QEMU devel list very often)
agree - since we, naturally, do various in-house setups with QEMU for
MIPS, that's all. This could count as the discussion on the patch, not
as a part of that loooooong "deprecated" state...
All is well,
Aleksandar
The process lasts for 2 releases before we delete anything:
https://qemu.weilnetz.de/doc/qemu-doc.html#Deprecated-features
When we start the clock now, it is deprecated when 5.0 releases
in April 2020, and still deprecated with 5.1 in August 2020.
The code won't be deleted until Sep 2020 when 5.2 dev cycle opens,
and there's still time to undelete it right up until the 5.2 feature
freeze in late Oct 2020. That's 11 months away, which is plenty of
time for feedback IMHO.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|