On Thu, Nov 12, 2020 at 05:18:06PM +0100, Michal Privoznik wrote:
On 11/12/20 3:46 PM, Peter Krempa wrote:
Saying that virDomainQemuAgentCommand is fully supported to be used would free us from having to add arbitrary unextendable APIs for every single guest agent API, but would still allow libvirt to use APIs we need.
By saying that mgmt apps will need to learn json apart from xml. I'm not saying it's necessarily a bad thing - mgmt application is probably written in a language that already has a JSON library built in (golang, python).
You also loose the benefit of libvirt's API abstraction. If QEMU guest agent is replaced by something different in future, a formal API in libvirt insulates the apps from that difference, both within context of a single hypervisor, and cross hypervisor. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|