Re: [libvirt] [PATCH] conf: Parse guestfwd channel device info again

On Tue, 2018-08-21 at 11:01 +0200, Andrea Bolognani wrote: > On Mon, 2018-08-20 at 18:52 +0200, Michal Privoznik wrote: > [...] >> - if (def->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL && >> - def->targetType == VIR_DOMAIN_CHR_CHANNEL_TARGET_TYPE_GUESTFWD) { >> - VIR_DEBUG("Ignoring device address for gustfwd channel"); >> - } else if (virDomainDeviceInfoParseXML(xmlopt, node, >> - &def->info, flags) < 0) { >> + if (virDomainDeviceInfoParseXML(xmlopt, node, &def->info, flags) < 0) >> goto error; >> - } >> - > > I agree that fixing Bug 1610072 is more important than preventing > Bug 1172526 from showing up again, but it would be great if we could > make it so both are fixed... > > How about parsing the info and then clearing out the address only if > it's a guestfwd channel? The existing virDomainDeviceInfoClear() is > a bit too thorough, but perhaps you can introduce a new > virDomainDeviceInfoClearAddress() that only zeroes out the address > and use that here. Given the issues with the approach I proposed, let's just cut our losses and merge your original attempt instead. Sorry for wasting your time :(

Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt;