Re: [libvirt] [PATCH 2/3] util: do not repeat the pm-is-supported string

14 Aug 2019


      On Tue, 2019-08-13 at 17:24 +0200, Ján Tomko wrote:
...
+++ b/src/util/virnodesuspend.c
     case VIR_NODE_SUSPEND_TARGET_HYBRID:
-        cmd = virCommandNewArgList("pm-is-supported", "--suspend-hybrid", NULL);
+        cmd = virCommandNewArgList(binary, "--suspend-hybrid", NULL);
         break;
     default:
-        return ret;
+        return -1;
     }
Yeah, this last hunk should have been in the first patch O:-)

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization