On 02/02/2011 05:07 AM, Daniel P. Berrange wrote:
On Tue, Feb 01, 2011 at 09:48:54AM -0700, Eric Blake wrote:
Qemu smartcard support exists on branches (such as http://cgit.freedesktop.org/~alon/qemu/commit/?h=usb_ccid.v15&id=024a37b) but is not yet upstream. Once an upstream version exists, then we can add new -help and -device ? output files to tests/qemuhelptest to prove that the new flag works.
* src/qemu/qemu_capabilities.h (QEMUD_CMD_FLAG_USB_CCID): New flag. * src/qemu/qemu_capabilities.c (qemuCapsExtractDeviceStr) (qemuCapsParseDeviceStr): Check for smartcard device support.
ACK
self-NACK. I'm intentionally holding off on pushing this series for just a bit longer, even though it has ACKs, since the qemu counterpart to this series is still not accepted upstream. In particular, I'll need a v5 of this series because this particular patch needs to check for ccid-card-emulated separately from ccid-card-passthrough (rather than assuming that usb-ccid implies both smartcard device implementations), now that the current upstream qemu patch series has added a configure option to skip ccid-card-emulated when NSS support is not desired. I also plan to fold in support for checking for spicevmc smartcard support at the same time (that is, I need three separate feature bits, not just one). I hope to post v5 later today. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org