On Mon, Feb 05, 2018 at 18:39:24 +0530, Shivaprasad bhat wrote:
Thanks for the reply Peter, Christian
On Fri, Feb 2, 2018 at 3:21 PM, Peter Krempa <pkrempa@redhat.com> wrote:
On Fri, Feb 02, 2018 at 08:14:29 +0100, Christian Ehrhardt wrote:
On Fri, Jan 19, 2018 at 3:55 PM, Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com> wrote:
The virt-aa-helper fails to parse the xmls with the memory/cpu hotplug features or user assigned aliases. Set the features in xmlopt->config for the parsing to succeed.
Signed-off-by: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com> --- src/security/virt-aa-helper.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index f7ccae0..29a459d 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -654,6 +654,11 @@ caps_mockup(vahControl * ctl, const char *xmlStr) return rc; }
+virDomainDefParserConfig virAAHelperDomainDefParserConfig = { + .features = VIR_DOMAIN_DEF_FEATURE_MEMORY_HOTPLUG | + VIR_DOMAIN_DEF_FEATURE_OFFLINE_VCPUPIN | + VIR_DOMAIN_DEF_FEATURE_INDIVIDUAL_VCPUS, +};
Sure we can't link against qemu_domain.c to get "the original" virQEMUDriverDomainDefParserConfig. But a comment here that the define is essentially taken there might helpful to later on follow any updates there.
Also mentioning why exactly you dropped VIR_DOMAIN_DEF_FEATURE_USER_ALIAS for the same reason.
The reason being the parsing code just ignores the user specified aliases and doesn't fail the parsing if the VIR_DOMAIN_DEF_FEATURE_USER_ALIAS feature flag is not set.
Ah, right. Sorry about that, I've only remembered the rest of the flags which usually end in a parse failure. In such case, ACK even without any modification currently. We can figure out the skipping of the parser features later.