Re: [PATCH] Fix missing-field-initializers error

On Thu, Jan 13, 2022 at 12:37:45AM +0800, Hyman wrote: CentOS 7 is no longer a supported build platform for libvirt (nor QEMU either) That GCC is used in Ubuntu 18.04 and isn't issuing warnings about this. Finally -Wmissing-field-initializers is explicitly documented as *not* issuing a warning for named fields [quote "info gcc"] '-Wmissing-field-initializers' Warn if a structure's initializer has some fields missing. For example, the following code causes such a warning, because 'x.h' is implicitly zero: struct s { int f, g, h; }; struct s x = { 3, 4 }; This option does not warn about designated initializers, so the following modification does not trigger a warning: struct s { int f, g, h; }; struct s x = { .f = 3, .g = 4 }; [/quote] Given CentOS 7 is no longer a supported platform, we can see GCC 7.5.0 works on other platforms, and the -Wmissing-field-initializers warning isn';t supposed to complain about this scenario, I don't want to take this patch. I'd also strongly encourage you to upgrade to a newer development platform, given CentOS 7 is explicitly not something the libvirt project wants to target anymore. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|