Re: [libvirt] [PATCH] qemu: change monitor.sock from /var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-***

On Fri, Oct 13, 2017 at 11:36:52AM +0800, xinhua.Cao wrote: Is that he only problem? I know it sounds right to have that in a runtime directory, but for me it would also make sense to have that in a persistent directory. Either this or any other file that suggests we did not clean up a domain yet. I'm not sure we are currently doing it or that it's a reason for why libDir was chosen, but it might have been. This is compatibility function that should be left alone so that we still guess the paths correctly for already launched qemu processes. More so, in both chunks here you are setting the domain's libDir which is used for more things than just the monitor. And, similarly to why the function above exists, you need to make sure we don't lose the track of some path just in case we did not save them anywhere in order for upgrades to go smoothly. Since this one has two versions, I believe I managed to save this into the stateXML, but I can't say for sure from the top of my head.