On 07/14/2011 09:19 AM, Matthias Bolte wrote:
2011/7/13 Eric Blake <eblake@redhat.com>:
Similar to the recent qemu_protocol-structs addition.
* src/virnetprotocol-structs: New file. * src/Makefile.am (%_protocol-structs): Factor body... (PDWTAGS): ...into new helper macro. (virnetprotocol-structs): New rule. (PROTOCOL_STRUCTS): Add virnetprotocol-structs. ---
In reply to: https://www.redhat.com/archives/libvir-list/2011-July/msg00602.html
src/Makefile.am | 24 +++++++++++++++--------- src/virnetprotocol-structs | 31 +++++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 9 deletions(-) create mode 100644 src/virnetprotocol-structs
Tested, works, ACK.
Thanks; pushed. Hmm, on looking further, I wonder if we need to also include enums in the *protocol-structs files. It looks odd seeing virNetMessageType used as a field member with no prior declaration - meaning that if someone botches the enum type, we won't catch that botch. I'll see about a followup patch. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org