28 Feb
2019
28 Feb
'19
3:30 p.m.
On 2/28/19 4:10 PM, Jiri Denemark wrote:
Both block_size and nb_block are unit32_t and multiplying them overflows at 4GiB.
Moreover, the iscsi_*10_* APIs use 32bit number of blocks and thus they can only address images up to 2TiB with 512B blocks. Let's use 64b iscsi_*16_* APIs instead.
Signed-off-by: Jiri Denemark <jdenemar@redhat.com> ---
Notes: Version 2: - also fix volumes > 2TiB
src/storage/storage_backend_iscsi_direct.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
ACK and safe for the freeze. Michal