On Mon, 2017-04-03 at 16:38 +0200, Peter Krempa wrote:
+int virStorageUtilGlusterExtractPoolSources(const char *host, + const char *xml, + virStoragePoolSourceListPtr list, + bool netfs); Please add a comment along the lines of "For test suite use only" here. Ideally we'd have a separate *priv.h header file to be used for the purpose, but that's out of scope. Why? This function can be used wherever it's necessary. It's by no-means specific to the test suite.
It would probably be a static function, or would never have been ripped out of virStorageBackendFindGlusterPoolSources() to begin with, were not for the test suite, so I'd say the comment would be warranted until a non-theoretical use for it is found outside of the test suite. If you don't feel the same way, you can safely disregard my remark though. -- Andrea Bolognani / Red Hat / Virtualization