On Wed, Mar 28, 2018 at 10:42:51 +0200, Andrea Bolognani wrote:
On Tue, 2018-03-27 at 20:48 +0200, Peter Krempa wrote:
On Tue, Mar 27, 2018 at 18:19:43 +0200, Andrea Bolognani wrote:
This reverts commit c190e17fb8f689a0591dedded33d10cecafe3e20.
As the original commit message so eloquently explains, the diff contains the tweaks I need for my local setup and it was, of course, never supposed to be pushed :/
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
One of the actually useful things about the commit hook we have is that if you don't sign-off the commit you can't push it. Thus you should not sign-off commits which are not ready ...
Good point.
I've changed my setup to generate S-o-bs at format-patch time rather than commit time, so hopefully this won't happen again.
And does that add the S-o-b to your local commits too? If it only signs-off the formatted mails, it's kind of useless, since you won't be able to push them until you add the signoffs locally.