Re: [libvirt] [PATCH libvirt 4/5] tests: add qemu-1.1-rc0 data
On Fri, May 04, 2012 at 11:30:21 -0600, Eric Blake wrote:
On 05/04/2012 11:22 AM, Marc-André Lureau wrote:
> Generated with qemu-system-x86_64 -device ? -device virtio-blk-pci,?
> -device virtio-net-pci,? 2> tests/qemuhelpdata/qemu-1.1-device
>
> With QEMU v1.1-rc0
> ---
> tests/qemuhelpdata/qemu-1.1 | 266 ++++++++++++++++++++++++++++++++++++
> tests/qemuhelpdata/qemu-1.1-device | 95 +++++++++++++
> tests/qemuhelptest.c | 70 ++++++++++
> 3 files changed, 431 insertions(+)
> create mode 100644 tests/qemuhelpdata/qemu-1.1
> create mode 100644 tests/qemuhelpdata/qemu-1.1-device
I'm wondering if rc0 is the right target. Since this patch series came
in after the libvirt 0.9.12 freeze, I'm thinking it might be better to
defer this series to 0.9.13, in which case we might as well wait for
qemu 1.1-rc1 or even the official qemu 1.1 final, and use that as our
test instead of rc0.
Yeah, rc0 is definitely not a good target since it contains a bug in
-device foo,? The list of device properties is very short (there is just one
of them, to be precise) in rc0, thus rc1 updated to 1.1 final, which should be
released in about the same time as libvirt-0.9.13 seems like a better target.
Jirka