Re: [libvirt] [jenkins-ci PATCH] Switch libvirt-dbus builds to Meson
On Mon, 2019-09-23 at 15:43 +0200, Pavel Hrdina wrote:
On Mon, Sep 23, 2019 at 03:03:47PM +0200, Andrea Bolognani wrote:
> Anyway, while I agree that in theory this is extremely simple to
> solve, I'd like to see that theory put into practice before we cut
> any release that requires Meson.
Meson 0.49.0 depends on Ninja 1.5 or newer and that is available on
all supported distros. On some of them the package is called `ninja`
and the rest uses `ninja-build`.
On CentOS/RHEL 7 the package is available only from EPEL.
On RHEL 8 the package is available from CodeReady Linux Builder
repository.
On CentOS 8 it should be available as well.
Thanks for taking the time to investigate this! It looks like we're
indeed covered as far as Ninja is concerned.
I'm not sure if we have EPEL repository in our CI VMs, but it
should be
fairly easy to enable and in fact if there is someone using upstream
libvirt on CentOS/RHEL 7 they most likely have EPEL enabled as well.
We don't have it enabled, but a while ago we agreed that it's
acceptable to add it to the CentOS guests, so installing Ninja from
EPEL shouldn't be a problem.
Installing Meson using pip should be simple to implement.
I agree that it's almost certainly just a matter of sitting down
and, you know, actually implementing it :) But let me reiterate that
I don't think we should consider releasing a version of libvirt-dbus
that uses Meson for builds until we have proper Meson support in our
CI. Perhaps we're all on the same page already and this wouldn't
even need mentioning, but I'm being extremely clear about my position
just in case.
--
Andrea Bolognani / Red Hat / Virtualization