RE: [libvirt] [PATCH] add fullscreen support to qemu sdl xml (via fullscreen='true' attribute for the graphics element)

-----Original Message----- From: Daniel Veillard [mailto:veillard@redhat.com] Sent: Wednesday, December 10, 2008 9:49 AM To: Itamar Heim Cc: Libvir-list(a)redhat.com Subject: Re: [libvirt] [PATCH] add fullscreen support to qemu sdl xml (via fullscreen='true' attribute for the graphics element) On Tue, Dec 09, 2008 at 07:12:05PM -0500, Itamar Heim wrote: > diff --git a/src/domain_conf.c b/src/domain_conf.c Hum, I don't know how you sent the diff, but it got broken when reaching my mail agent. Please add as an attachment. Also in general it's a good idea to put some text describing really what the patch does and what is affected, a one line mail subject is a bit short. Especially for thing modifying the XML format, the construct changes ought to be clearly documented. Adding the regression tests is nice, thanks, but we also need to augment the .rng schemas to handle the extension if accepted and the HTML documentation also need the update. We can do it but providing the complete details helps :-) So could you please repost the patch with detail of the syntax change and as an attachment, thanks in advance, Daniel > + if (vm->def->graphics->data.sdl.fullscreen && > > + STREQ(vm->def->graphics->data.sdl.fullscreen, "true")) { > > + fullscreen=true; > > + } > > + -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/