Re: [PATCH v2 01/30] access: Remove unused includes

On a Saturday in 2022, Peng Liang wrote: > Signed-off-by: Peng Liang <tcx4c70(a)gmail.com&gt; > --- > src/access/viraccessdriver.h       | 1 - > src/access/viraccessdriverpolkit.c | 4 ---- > src/access/viraccessdriverstack.c  | 1 - > src/access/viraccessmanager.h      | 1 - > src/access/viraccessperm.h         | 1 - > 5 files changed, 8 deletions(-) > > diff --git a/src/access/viraccessperm.h b/src/access/viraccessperm.h > index 051246a7b6..b0ee36ed3a 100644 > --- a/src/access/viraccessperm.h > +++ b/src/access/viraccessperm.h > @@ -20,7 +20,6 @@ > > #pragma once > > -#include "internal.h" While internal.h might be unused here, I'd rather not remove it. Besides being very commonly used it also contains things for backward compatibility with older Glib versions. If we forget to re-add it later, libvirt might silently misbehave with older Glib. Jano

> #include "virenum.h" > > typedef enum { > --  > 2.36.1 >