Re: [libvirt] [PATCH v2 01/11] s390: Cpu driver support for update and compare

Implement compare for s390. Required to test the guest against the host for guest cpu model runnability checking. We always return IDENTICAL to bypass Libvirt's checking. s390 will rely on Qemu to perform the runnability checking. Implement update for s390. required to support use of cpu "host-model" mode. Signed-off-by: Jason J. Herne <jjherne(a)linux.vnet.ibm.com&gt; --- po/POTFILES.in | 1 + src/cpu/cpu_s390.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 72 insertions(+), 2 deletions(-)

diff --git a/src/cpu/cpu_s390.c b/src/cpu/cpu_s390.c index 04a6bea..3efc948 100644 --- a/src/cpu/cpu_s390.c +++ b/src/cpu/cpu_s390.c

+static int +virCPUs390Update(virCPUDefPtr guest, + const virCPUDef *host)

+ for (i = 0; i < guest->nfeatures; i++) { + if (guest->features[i].policy == VIR_CPU_FEATURE_OPTIONAL) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Only cpu feature policies 'require' and 'disable' are " + "supported for %s"), + guest->features[i].name);

+ goto cleanup; + } +