Re: [libvirt] [PATCH v2] network: allow to specify buffer size for netlink socket

On 07/16/2017 05:04 PM, Laine Stump wrote: > On 07/11/2017 09:01 PM, ZhiPeng Lu wrote: >> This patchs allow to set the buffer size for netlink socket in >> the libvirtd configuration file. The default buffer size remain >> as before at 128k. > See my more detailed response to your earlier patch here: > > > https://www.redhat.com/archives/libvir-list/2017-July/msg00566.html > > There should be no need to configure the initial libnl buffer size, > because we enable MSG_PEEK on the libnl sockets (and recent versions of > libnl have it turned on by default anyway). If that's not permitting the > buffer to auto-grow as necessary, then there is a different bug somewhere. > If an old version of libnl is the problem, then perhaps a patch which just adds a comment in virNetlinkCreateSocket to "summarize" what gets discovered w/r/t MSG_PEEK and the "correct" minimum version of libnl so that the "next" person to come this way will have a chance at understanding what needs to be done without going through the submit a patch changing the size again! All that said, having it be configurable could be useful for someone who has a system that doesn't have that version, while still working as expected for the right version.