On 05/12/2011 03:47 PM, Cole Robinson wrote:
Use capabilities to allow a driver to register a default <init> if none is specified in the XML. Openvz was already open-coding this to be /sbin/init
LXC currently falls over if no init is specified, so an explicit error is an improvement IMO.
(Side note: I don't think we can set a default value for LXC. If we use /sbin/init but the user doesn't specify a separate root FS for their guest, the container will rerun the host's init which can be traumatic :). For virt-install I'm thinking of defaulting to /sbin/init if a root FS has been specified, otherwise require the user to manually specify <init>)
Signed-off-by: Cole Robinson <crobinso@redhat.com> --- src/conf/capabilities.h | 1 + src/conf/domain_conf.c | 12 ++++++++++++ src/openvz/openvz_conf.c | 4 +++- src/openvz/openvz_driver.c | 14 -------------- 4 files changed, 16 insertions(+), 15 deletions(-)
ACK. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org