On Mon, Aug 13, 2018 at 11:21:44AM +0200, Michal Privoznik wrote:
We are freeing the individual strings (which were filled by virNetDevIPCheckIPv6ForwardingCallback()) but not the array itself.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/util/virnetdevip.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index c6d6175627..866ddcc213 100644 --- a/src/util/virnetdevip.c +++ b/src/util/virnetdevip.c @@ -651,8 +651,7 @@ virNetDevIPCheckIPv6Forwarding(void)
cleanup: nlmsg_free(nlmsg); - for (i = 0; i < data.ndevices; i++) - VIR_FREE(data.devices[i]); + virStringListFreeCount(data.devices, data.ndevices); return valid;
Reviewed-by: Erik Skultety <eskultet@redhat.com>