On Tue, Jul 28, 2020 at 07:35:11PM +0800, zhukeqian wrote:
On 2020/7/28 18:32, Daniel P. Berrangé wrote:
On Wed, Jul 15, 2020 at 02:18:01PM +0800, Keqian Zhu wrote:
For that Qemu supports returning incoming migration info since its commit 65ace0604551 (migration: add postcopy total blocktime into query-migrate), which may contains active status, but without RAM info. Drop this binding relationship check in libvirt.
I'm not clear from this description what the actual bug in libvirt is ? What currently fails in libvirt that this patch fixes ?
When query migration status, libvirt assumes that when migration status is active, then RAM info must be set. However qemu has changed this assumption, so libvirt will report "migration was active, but no RAM info was set" when query migration info.
So you're trying to make it possible to query migration stats on the destination host ? IOW, this is a new feature, rather than a bug fix ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|