On 01/12/2015 08:06 AM, Ian Campbell wrote:
On Fri, 2015-01-09 at 22:03 -0700, Jim Fehlig wrote:
> The first attempt to implement support for parsing/formatting Xen's
> xl disk config format copied Xen's flex-based parser into libvirt, which
> has proved to be challenging in the context of autotools. But as it turns
> out, Xen provides an interface to the parser via libxlutil.
>
> This series reverts the first attempt, along with subsequent attempts to
> fix it, and replaces it with an implementation based on libxlutil. The
> first nine patches revert the original implementation and subsequent fixes.
> Patch 10 provides an implemenation based on libxlutil. Patches 11 and
> 12 are basically unchanged from patches 3 and 4 in the first attempt.
>
> One upshot of using libxlutil instead of copying the flex source is
> removing the potential for source divergence.
Thanks for doing this, looks good to me, FWIW.
Is the presence/absence of xen-xl support exposed via virsh anywhere? If
so then I can arrange for my Xen osstest patches for libvirt testing to
use xen-xl when available but still fallback to xen-xm. I've had a look
in "virsh capabilities" and "virsh help domxml-from-native" but not
seeing xen-xm, so assuming xen-xl won't magically appear in any of those
places either.
I'm not sure if 'virsh capabilities' can show it, but it does sound like
a nice place to enhance if possible.
Also, if 'virsh --version=long' doesn't state whether libxl support was
compiled in, it should be patched to do so; although that only shows
what the client side supports (and not necessarily what the remote
server side supports).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org