Markus Armbruster <armbru@redhat.com> wrote:
Juan Quintela <quintela@redhat.com> writes:
-# @deprecated: @disk migration is deprecated. Use driver-mirror -# with NBD instead. +# @deprecated: @disk migration is deprecated. Use driver-mirror with +# NBD instead. @compression is unreliable and untested. It is +# recommended to use multifd migration, which offers an +# alternative compression implementation that is reliable and +# tested.
Again, single deprecation note under "Features:", please.
Done in all places.
# # Since: 0.14 ## @@ -290,7 +295,7 @@ '*blocked-reasons': ['str'], '*postcopy-blocktime': 'uint32', '*postcopy-vcpu-blocktime': ['uint32'], - '*compression': 'CompressionStats', + '*compression': { 'type': 'CompressionStats', 'features': ['deprecated'] }, '*socket-address': ['SocketAddress'], '*dirty-limit-throttle-time-per-round': 'uint64', '*dirty-limit-ring-full-time': 'uint64'} } @@ -445,7 +450,8 @@ # compress and xbzrle are both on, compress only takes effect in # the ram bulk stage, after that, it will be disabled and only # xbzrle takes effect, this can help to minimize migration -# traffic. The feature is disabled by default. (since 2.4 ) +# traffic. The feature is disabled by default. Obsolete. Use
Some places call it "deprecated", others "obsolete". Best to always use "deprecated".
"obsolete" word removed from this series O:-)
More of the same below.
+# multifd compression methods if needed. (since 2.4 ) # # @events: generate events for each migration state change (since 2.4 # )
[...]
Migration has grown way too many options. Thanks for pruning them back some.
I am going to redo the 1st patches to just print an error if you use -i/-b on HMP. So that will clean up your last comment for that patch. Thanks.