Re: [libvirt] [PATCH 4/5] numad: Divide cur_balloon by 1024 before passing it to numad

On 05/08/2012 04:29 PM, Eric Blake wrote: > On 05/08/2012 10:04 AM, Osier Yang wrote: >> Numad expects MB by default. >> --- >> src/qemu/qemu_process.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c >> index 82b17d6..e34cc6d 100644 >> --- a/src/qemu/qemu_process.c >> +++ b/src/qemu/qemu_process.c >> @@ -1773,7 +1773,7 @@ qemuGetNumadAdvice(virDomainDefPtr def) >> >> cmd = virCommandNewArgList(NUMAD, "-w", NULL); >> virCommandAddArgFormat(cmd, "%d:%llu", def->vcpus, >> - def->mem.cur_balloon); >> + VIR_DIV_UP(def->mem.cur_balloon, 1024)); > > ACK. This is borderline between new feature (since it is new XML) and bug fix, but I'm leaning towards bug-fix, since otherwise our use of numad is not very efficient given the default XML that people used to just place<vcpu>. Therefore, I've gone ahead and pushed the first four patches in time for 0.9.12.