Re: [libvirt PATCH 113/351] meson: add debug_logs build option

On Thu, Jul 16, 2020 at 11:55:49 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > --- > configure.ac | 3 --- > m4/virt-debug.m4 | 33 --------------------------------- > meson.build | 5 +++++ > meson_options.txt | 1 + > 4 files changed, 6 insertions(+), 36 deletions(-) > delete mode 100644 m4/virt-debug.m4 ... > @@ -2175,6 +2179,7 @@ test_summary = { > summary(test_summary, section: 'Test suite', bool_yn: true) > > misc_summary = { > + 'Debug': conf.has('ENABLE_DEBUG'), > 'Use -Werror': cc_flags.contains('-Werror'), > 'Warning Flags': supported_cc_flags, > 'Char device locks': chrdev_lock_files, > diff --git a/meson_options.txt b/meson_options.txt > index 1f32533f0f5..a09dad02875 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -91,3 +91,4 @@ option('storage_zfs', type: 'feature', value: 'auto', description: 'ZFS backend > > # build feature options > option('chrdev_lock_files', type: 'string', value: '', description: 'location for UUCP style lock files for character devices (leave empty for default paths on some platforms)') > +option('debug_logs', type: 'boolean', value: true, description: 'enable debugging output') IMO, we should completely remove ENABLE_DEBUG macro. Users can configure logging via our log filters and this seems to be really pointless. (The only thing it does is to make 'VIR_DEBUG/VIR_INFO/VIR_WARN and VIR_ERROR macros do nothing)