Re: [libvirt] [PATCH v2 04/14] qemuBuildInterfaceCommandLine: Move vhostuser handling a bit further
On 13.10.2016 22:58, John Ferlan wrote:
On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> The idea is to have function that does some checking of the
> arguments at its beginning and then have one big switch for all
> the interface types it supports. Each one of them generating the
> corresponding part of the command line.
>
> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
> ---
> src/qemu/qemu_command.c | 9 +++---
> .../qemuxml2argv-net-vhostuser-fail.xml | 36 ++++++++++++++++++++++
> tests/qemuxml2argvtest.c | 3 ++
> 3 files changed, 44 insertions(+), 4 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-net-vhostuser-fail.xml
>
Similarly to patch 3, if a vhost-user entry contains 'filterref' or
'backend tap', then bulding will fail. Although queues is Ok.
BTW: I just realized cfg isn't even used in this function other than the
GetConfig call and Unref call.
Yes, I've noticed that too and I'm fixing it somewhere in a later patch.
Michal